Remove ClientParseError type and use JSON.stringify in place of serializeFetchParameter

.api-reports/api-report-core.api.md

@@ -12,7 +12,6 @@ import type { ApplyHKTImplementationWithDefault } from '@apollo/client/utilities
 import { Cache as Cache_2 } from '@apollo/client/cache';
 import { checkFetcher } from '@apollo/client/link/http';
 import type { ClientAwarenessLink } from '@apollo/client/link/client-awareness';
-import { ClientParseError } from '@apollo/client/link/http';
 import { CombinedGraphQLErrors } from '@apollo/client/errors';
 import { CombinedProtocolErrors } from '@apollo/client/errors';
 import { concat } from '@apollo/client/link';
@@ -88,7 +87,6 @@ import { rewriteURIForGET } from '@apollo/client/link/http';
 import { selectHttpOptionsAndBody } from '@apollo/client/link/http';
 import { selectHttpOptionsAndBodyInternal } from '@apollo/client/link/http';
 import { selectURI } from '@apollo/client/link/http';
-import { serializeFetchParameter } from '@apollo/client/link/http';
 import { ServerError } from '@apollo/client/errors';
 import { ServerParseError } from '@apollo/client/errors';
 import { setVerbosity as setLogVerbosity } from '@apollo/client/utilities/invariant';
@@ -388,8 +386,6 @@ export { Cache_2 as Cache }
 
 export { checkFetcher }
 
-export { ClientParseError }
-
 export { CombinedGraphQLErrors }
 
 export { CombinedProtocolErrors }
@@ -1031,8 +1027,6 @@ export { selectHttpOptionsAndBodyInternal }
 
 export { selectURI }
 
-export { serializeFetchParameter }
-
 export { ServerError }
 
 export { ServerParseError }

.api-reports/api-report-link_http.api.md

@@ -7,7 +7,6 @@
 import { ApolloLink } from '@apollo/client/link';
 import type { ASTNode } from 'graphql';
 import { ClientAwarenessLink } from '@apollo/client/link/client-awareness';
-import type { InvariantError } from '@apollo/client/utilities/invariant';
 import type { print as print_2 } from '@apollo/client/utilities';
 
 // @public (undocumented)
@@ -18,11 +17,6 @@ export class BaseHttpLink extends ApolloLink {
 // @public (undocumented)
 export const checkFetcher: (fetcher: typeof fetch | undefined) => void;
 
-// @public (undocumented)
-export type ClientParseError = InvariantError & {
-    parseError: Error;
-};
-
 // @public @deprecated (undocumented)
 export const createHttpLink: (linkOptions?: HttpLink.Options & ClientAwarenessLink.Options) => HttpLink;
 
@@ -140,9 +134,6 @@ export function selectHttpOptionsAndBodyInternal(operation: ApolloLink.Operation
 // @public (undocumented)
 export const selectURI: (operation: ApolloLink.Operation, fallbackURI?: string | ((operation: ApolloLink.Operation) => string)) => any;
 
-// @public (undocumented)
-export const serializeFetchParameter: (p: any, label: string) => string;
-
 // (No @packageDocumentation comment for this package)
 
 ```

.api-reports/api-report.api.md

@@ -679,13 +679,6 @@ class ClientAwarenessLink extends ApolloLink {
     constructor(constructorOptions?: ClientAwarenessLink.Options);
 }
 
-// Warning: (ae-forgotten-export) The symbol "InvariantError" needs to be exported by the entry point index.d.ts
-//
-// @public (undocumented)
-export type ClientParseError = InvariantError & {
-    parseError: Error;
-};
-
 // Warning: (ae-forgotten-export) The symbol "Prettify" needs to be exported by the entry point index.d.ts
 // Warning: (ae-forgotten-export) The symbol "MergeUnions" needs to be exported by the entry point index.d.ts
 // Warning: (ae-forgotten-export) The symbol "ExtractByMatchingTypeNames" needs to be exported by the entry point index.d.ts
@@ -1566,11 +1559,6 @@ interface InvalidateModifier {
 // @public (undocumented)
 const _invalidateModifier: unique symbol;
 
-// @public (undocumented)
-class InvariantError extends Error {
-    constructor(message?: string);
-}
-
 // @internal @deprecated (undocumented)
 type IsAny<T> = 0 extends 1 & T ? true : false;
 
@@ -2545,9 +2533,6 @@ export function selectHttpOptionsAndBodyInternal(operation: ApolloLink.Operation
 // @public (undocumented)
 export const selectURI: (operation: ApolloLink.Operation, fallbackURI?: string | ((operation: ApolloLink.Operation) => string)) => any;
 
-// @public (undocumented)
-export const serializeFetchParameter: (p: any, label: string) => string;
-
 // @public (undocumented)
 export namespace ServerError {
     // (undocumented)

.changeset/friendly-news-drive.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": major
+---
+
+The `serializeFetchParameter` helper is no longer exported and `JSON.stringify` is used directly. As such, the `ClientParseError` type has also been removed in favor of throwing any JSON serialize errors directly.

.size-limits.json

@@ -1,6 +1,6 @@
 {
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (CJS)": 44063,
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (production) (CJS)": 38714,
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\"": 33609,
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (production)": 27632
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (CJS)": 43798,
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (production) (CJS)": 38629,
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\"": 33543,
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (production)": 27562
 }

src/__tests__/__snapshots__/exports.ts.snap

@@ -43,7 +43,6 @@ Array [
   "selectHttpOptionsAndBody",
   "selectHttpOptionsAndBodyInternal",
   "selectURI",
-  "serializeFetchParameter",
   "setLogVerbosity",
   "split",
   "version",
@@ -110,7 +109,6 @@ Array [
   "selectHttpOptionsAndBody",
   "selectHttpOptionsAndBodyInternal",
   "selectURI",
-  "serializeFetchParameter",
   "setLogVerbosity",
   "split",
   "version",
@@ -210,7 +208,6 @@ Array [
   "selectHttpOptionsAndBody",
   "selectHttpOptionsAndBodyInternal",
   "selectURI",
-  "serializeFetchParameter",
 ]
 `;
 

src/core/index.ts

@@ -133,9 +133,7 @@ export {
   // TODO remove: needed by @apollo/client/link/batch-http but not public
   selectHttpOptionsAndBodyInternal,
   selectURI,
-  serializeFetchParameter,
 } from "@apollo/client/link/http";
-export type { ClientParseError } from "@apollo/client/link/http";
 
 /* Masking */
 export type {

src/link/batch-http/batchHttpLink.ts

@@ -12,7 +12,6 @@ import {
   parseAndCheckHttpResponse,
   selectHttpOptionsAndBodyInternal,
   selectURI,
-  serializeFetchParameter,
 } from "@apollo/client/link/http";
 import { filterOperationVariables } from "@apollo/client/link/utils";
 import { __DEV__ } from "@apollo/client/utilities/environment";
@@ -132,7 +131,7 @@ export class BaseBatchHttpLink extends ApolloLink {
       }
 
       try {
-        (options as any).body = serializeFetchParameter(loadedBody, "Payload");
+        (options as any).body = JSON.stringify(loadedBody);
       } catch (parseError) {
         return throwError(() => parseError);
       }

src/link/http/BaseHttpLink.ts

@@ -23,7 +23,6 @@ import {
   selectHttpOptionsAndBodyInternal,
 } from "./selectHttpOptionsAndBody.js";
 import { selectURI } from "./selectURI.js";
-import { serializeFetchParameter } from "./serializeFetchParameter.js";
 
 const backupFetch = maybe(() => fetch);
 
@@ -108,7 +107,7 @@ export class BaseHttpLink extends ApolloLink {
           }
           chosenURI = newURI;
         } else {
-          options.body = serializeFetchParameter(body, "Payload");
+          options.body = JSON.stringify(body);
         }
         // Prefer linkOptions.fetch (preferredFetch) if provided, and otherwise
         // fall back to the *current* global window.fetch function (see issue

src/link/http/__tests__/HttpLink.ts

@@ -32,8 +32,6 @@ import {
   wait,
 } from "@apollo/client/testing/internal";
 
-import type { ClientParseError } from "../serializeFetchParameter.js";
-
 import { voidFetchDuringEachTest } from "./helpers.js";
 
 const sampleQuery = gql`
@@ -395,10 +393,7 @@ describe("HttpLink", () => {
 
       const error = await stream.takeError();
 
-      expect(error.message).toMatch(/Variables map is not serializable/);
-      expect(error.parseError.message).toMatch(
-        /Converting circular structure to JSON/
-      );
+      expect(error.message).toMatch(/Converting circular structure to JSON/);
     });
 
     it("throws for GET if the extensions can't be stringified", async () => {
@@ -421,10 +416,7 @@ describe("HttpLink", () => {
 
       const error = await stream.takeError();
 
-      expect(error.message).toMatch(/Extensions map is not serializable/);
-      expect(error.parseError.message).toMatch(
-        /Converting circular structure to JSON/
-      );
+      expect(error.message).toMatch(/Converting circular structure to JSON/);
     });
 
     it("does not need any constructor arguments", () => {
@@ -1114,12 +1106,9 @@ describe("HttpLink", () => {
       const observable = execute(link, { query: sampleQuery, variables });
       const stream = new ObservableStream(observable);
 
-      const error: ClientParseError = await stream.takeError();
+      const error = await stream.takeError();
 
-      expect(error.message).toMatch(/Payload is not serializable/);
-      expect(error.parseError.message).toMatch(
-        /Converting circular structure to JSON/
-      );
+      expect(error.message).toMatch(/Converting circular structure to JSON/);
     });
 
     describe("AbortController", () => {

src/link/http/index.ts

@@ -1,6 +1,4 @@
 export { parseAndCheckHttpResponse } from "./parseAndCheckHttpResponse.js";
-export type { ClientParseError } from "./serializeFetchParameter.js";
-export { serializeFetchParameter } from "./serializeFetchParameter.js";
 export {
   defaultPrinter,
   fallbackHttpConfig,

src/link/http/rewriteURIForGET.ts

@@ -1,5 +1,4 @@
 import type { HttpLink } from "./HttpLink.js";
-import { serializeFetchParameter } from "./serializeFetchParameter.js";
 
 // For GET operations, returns the given URI rewritten with parameters, or a
 // parse error.
@@ -20,10 +19,7 @@ export function rewriteURIForGET(chosenURI: string, body: HttpLink.Body) {
   if (body.variables) {
     let serializedVariables;
     try {
-      serializedVariables = serializeFetchParameter(
-        body.variables,
-        "Variables map"
-      );
+      serializedVariables = JSON.stringify(body.variables);
     } catch (parseError) {
       return { parseError };
     }
@@ -32,10 +28,7 @@ export function rewriteURIForGET(chosenURI: string, body: HttpLink.Body) {
   if (body.extensions) {
     let serializedExtensions;
     try {
-      serializedExtensions = serializeFetchParameter(
-        body.extensions,
-        "Extensions map"
-      );
+      serializedExtensions = JSON.stringify(body.extensions);
     } catch (parseError) {
       return { parseError };
     }

src/utilities/subscriptions/relay/index.ts

@@ -2,7 +2,6 @@ import type { GraphQLResponse, RequestParameters } from "relay-runtime";
 import { Observable } from "relay-runtime";
 
 import type { OperationVariables } from "@apollo/client";
-import { serializeFetchParameter } from "@apollo/client";
 import type { HttpLink } from "@apollo/client/link/http";
 import { maybe } from "@apollo/client/utilities/internal/globals";
 
@@ -35,7 +34,7 @@ export function createFetchMultipartSubscription(
 
     return Observable.create((sink) => {
       try {
-        options.body = serializeFetchParameter(body, "Payload");
+        options.body = JSON.stringify(body);
       } catch (parseError) {
         sink.error(parseError as Error);
       }