-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Harden CI steps #13236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden CI steps #13236
Changes from all commits
889f7c6
5a296c4
cc784fc
bcea81a
fb002a2
5d9ab49
4353bc4
46b463b
b3d87c5
90bef7a
ded9ad3
3394faa
4b2fccb
21b677b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,9 @@ on: | |
|
|
||
| concurrency: ${{ github.workflow }}-${{ github.ref }} | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| comparebuildoutput: | ||
| name: Compare Build Output | ||
|
|
@@ -14,15 +17,16 @@ jobs: | |
| with: | ||
| # Fetch entire git history so we have the parent commit to compare against | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 | ||
| with: | ||
| node-version: ">=23.6.0" | ||
| - name: Install dependencies (with cache) | ||
| uses: bahmutov/npm-install@v1 | ||
| uses: bahmutov/npm-install@20216767ca67f0f7b4d095dc5859c5700a6581cb # v1 | ||
|
|
||
| - name: Run comparison script | ||
| id: attw | ||
| run: ./config/compare-build-output-to.sh $(git merge-base HEAD origin/${{ github.base_ref }}) | tee $GITHUB_STEP_SUMMARY | ||
| run: ./config/compare-build-output-to.sh $(git merge-base HEAD origin/${GITHUB_BASE_REF}) | tee $GITHUB_STEP_SUMMARY | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Out of curiosity, whats the difference here and why is the env variable better?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was an autofix if I remember correctly, so I didn't dig too deep into this, but apparently |
||
| env: | ||
| RUNNER_TEMP: ${{ runner.temp }} | ||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we even use this action anymore? actions/setup-node has a built-in cache so might be best to use that one. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy if we get rid of it, I just didn't want to do everything in one PR