Skip to content

Replace npm-install action with npm ci - #13247

Merged
phryneas merged 1 commit into
mainfrom
jerel/more-hardening
Jun 1, 2026
Merged

Replace npm-install action with npm ci#13247
phryneas merged 1 commit into
mainfrom
jerel/more-hardening

Conversation

@jerelmiller

@jerelmiller jerelmiller commented May 29, 2026

Copy link
Copy Markdown
Member

This PR switches away from the bahmutov/npm-install action to plain npm ci. If we want to use a cache, actions/setup-node includes it and we'd rather leverage that instead. This should reduce one more potential attack vector in case this action caches differently.

Summary by CodeRabbit

  • Chores
    • Updated continuous integration workflows to streamline dependency installation across all build pipelines for improved consistency and maintainability.

Review Change Stack

@apollo-librarian

apollo-librarian Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 546afaacb1308d68ac163fd9
Build Logs: View logs


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@changeset-bot

changeset-bot Bot commented May 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4055108

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a8439f4b-78e0-4b29-887b-970c9e6fd3a2

📥 Commits

Reviewing files that changed from the base of the PR and between 189d166 and 4055108.

📒 Files selected for processing (9)
  • .github/workflows/api-extractor.yml
  • .github/workflows/arethetypeswrong.yml
  • .github/workflows/cleanup-checks.yml
  • .github/workflows/compare-build-output.yml
  • .github/workflows/docmodel.yml
  • .github/workflows/knip.yml
  • .github/workflows/publish-pr-releases.yml
  • .github/workflows/scheduled-test-canary.yml
  • .github/workflows/size-limit.yml

📝 Walkthrough

Walkthrough

Nine GitHub Actions workflows are updated to install Node dependencies by running npm ci directly instead of using the cached bahmutov/npm-install action. The modification is applied uniformly across api-extractor, arethetypeswrong, cleanup-checks, compare-build-output, docmodel, knip, publish-pr-releases, scheduled-test-canary, and size-limit workflows.

Changes

CI Workflow Dependency Installation

Layer / File(s) Summary
Workflow dependency installation updates
.github/workflows/api-extractor.yml, .github/workflows/arethetypeswrong.yml, .github/workflows/cleanup-checks.yml, .github/workflows/compare-build-output.yml, .github/workflows/docmodel.yml, .github/workflows/knip.yml, .github/workflows/publish-pr-releases.yml, .github/workflows/scheduled-test-canary.yml, .github/workflows/size-limit.yml
All nine workflows replace the bahmutov/npm-install action with a direct npm ci run for dependency installation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

auto-cleanup

Poem

🐰 The workflows now run swift and clean,
With npm ci in every scene,
No cached action to delay,
Dependencies installed the simplest way! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing the bahmutov/npm-install action with npm ci across multiple GitHub Actions workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented May 29, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@13247

commit: 4055108

@phryneas
phryneas merged commit 7c5dcde into main Jun 1, 2026
49 checks passed
@github-actions github-actions Bot added the auto-cleanup 🤖 label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants