Add tests to check whether read function values are returned for incremental results - #13333
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 7c9694eb96c819f309dcfaa4 ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
|
|
|
||
| type Friend = { id: number; name: string }; | ||
|
|
||
| test.failing( |
There was a problem hiding this comment.
Many of these are test.failing (which I expected). .failing will be removed in #13324.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a GraphQL 17 Alpha 9 incremental delivery test suite covering cache field read functions across deferred fields, streamed lists, partial cache data, residual fills, overlapping selections, and nested objects. ChangesIncremental cache field reads
Estimated code review effort: 4 (Complex) | ~45 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
While implementing the incremental fixes in #13324, I noticed another case we aren't handling correctly with incremental streaming:
readfunctions are run, but the results are never applied to intermediate incremental results.cache.diffruns thereadfunctions, but because we only applydiff.resultwhendiff.complete(which isfalsewhen@deferchunks haven't streamed yet), we never see the transformed values.I want to make sure #13324 fixes most (if not all) of these cases, so I'm creating a separate test suite for this. These tests are added in a separate file to avoid conflicts with the test file changes from #13324. That PR will be remove this test file and copy over the tests to maintain a clean merge.
Summary by CodeRabbit
@deferand@stream.