Skip to content

Fix widening of default options types when variables contain constant types - #13352

Closed
jerelmiller wants to merge 3 commits into
mainfrom
jerel/complex-vars-default-options
Closed

Fix widening of default options types when variables contain constant types#13352
jerelmiller wants to merge 3 commits into
mainfrom
jerel/complex-vars-default-options

Conversation

@jerelmiller

@jerelmiller jerelmiller commented Jul 24, 2026

Copy link
Copy Markdown
Member

Fixes #13342

TypeScript playground of the reproduction: https://tsplay.dev/mAbMQW

@apollo-librarian

apollo-librarian Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: f73808ec9fc941dfa53ecb6f
Build Logs: View logs


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@changeset-bot

changeset-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f1d25c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 984c2637-12ff-443b-b0a2-93684a5c2d4a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 24, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@apollo/client@13352

commit: f1d25c9

@oceandrama

Copy link
Copy Markdown

Confirmed on our app (dam-client-web) with signatureStyle: "modern":

  • @apollo/client@4.2.7 — typecheck fails with DeepPartial / possibly 'undefined' on nested useQuery / useSuspenseQuery data (same as this issue)
  • https://pkg.pr.new/@apollo/client@13352 — typecheck passes cleanly with modern signatures enabled

So the fix in #13352 looks good for our real queries (complex variables / input objects). Thanks!

@jerelmiller

Copy link
Copy Markdown
Member Author

Superseded by #13382

@jerelmiller jerelmiller closed this Aug 4, 2026
@jerelmiller
jerelmiller deleted the jerel/complex-vars-default-options branch August 4, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modern useQuery: dataState includes "partial" for complex TVariables even when returnPartialData is false

2 participants