Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/cache/inmemory/__tests__/readFromStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,37 @@ describe("reading from the store", () => {
});
});

it("applies defaults when variable is explicitly undefined", () => {
const query = gql`
query someQuery($show: Boolean = false) {
id
field @include(if: $show)
}
`;

const variables = {
show: undefined,
};

const store = defaultNormalizedCacheFactory({
ROOT_QUERY: {
__typename: "Query",
id: "abcd",
} as StoreObject,
});

const result = readQueryFromStore(reader, {
store,
query,
variables,
});

// $show defaults to false, so @include(if: false) excludes the field
expect(result).toEqual({
id: "abcd",
});
});

it("runs a nested query", () => {
const result: any = {
id: "abcd",
Expand Down
5 changes: 4 additions & 1 deletion src/cache/inmemory/readFromStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,12 @@ export class StoreReader {
}: DiffQueryAgainstStoreOptions): Cache.DiffResult<T> {
const policies = this.config.cache.policies;

const rawVariables = variables ?? {};
variables = {
...getDefaultValues(getQueryDefinition(query)),
...variables!,
...Object.fromEntries(
Object.entries(rawVariables).filter(([, v]) => v !== undefined)
),
};

const rootRef = makeReference(rootId);
Expand Down