Skip to content

Add unique-names anchor to fragments docs - #13363

Closed
atharv-sys32 wants to merge 1 commit into
apollographql:mainfrom
atharv-sys32:docs/unique-names-anchor
Closed

Add unique-names anchor to fragments docs#13363
atharv-sys32 wants to merge 1 commit into
apollographql:mainfrom
atharv-sys32:docs/unique-names-anchor

Conversation

@atharv-sys32

@atharv-sys32 atharv-sys32 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Fixes broken link in graphql-tag warning

Summary by CodeRabbit

  • Documentation
    • Added guidance that GraphQL fragment names must be unique across the application.
    • Documented runtime warnings for duplicate fragment names.
    • Recommended using descriptive, component-scoped fragment names to prevent naming collisions.

@atharv-sys32
atharv-sys32 requested a review from a team as a code owner July 28, 2026 17:47
@apollo-librarian

apollo-librarian Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

⚠️ AI Style Review — 1 Issue Found

Summary

The pull request updates the documentation style guide across four key sections: it refines product framing to focus on user assistance rather than trivializing tasks, prohibits the use of articles before standalone library names like 'graphql-tag', mandates an authoritative tone for prescribing best practices, and discourages the use of semicolons in favor of periods to enhance clarity.

Duration: 3096ms
Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e06ec68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d02a43c2-05fb-4fb3-a4e0-a4ab3f05bac7

📥 Commits

Reviewing files that changed from the base of the PR and between 8518419 and e06ec68.

📒 Files selected for processing (1)
  • docs/source/data/fragments.mdx

📝 Walkthrough

Walkthrough

Adds documentation requiring unique fragment names, explains the graphql-tag duplicate-name warning, and recommends descriptive component-scoped names.

Changes

Fragment documentation

Layer / File(s) Summary
Document unique fragment names
docs/source/data/fragments.mdx
Adds guidance on fragment name uniqueness, runtime warnings, and component-scoped naming.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bignimbus

Poem

A bunny hops through fragments bright,
Naming each one just right.
No duplicate names shall collide,
Component scopes keep them wide.
graphql-tag warns with care—
Clean little names bloom everywhere.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

docs/source/data/fragments.mdx

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant