Skip to content

Parse scalars for no-cache queries - #13372

Draft
jerelmiller wants to merge 31 commits into
release-4.3from
jerel/no-cache-scalars
Draft

Parse scalars for no-cache queries#13372
jerelmiller wants to merge 31 commits into
release-4.3from
jerel/no-cache-scalars

Conversation

@jerelmiller

Copy link
Copy Markdown
Member

I'm putting this up as a topic of discussion. It handles parsing custom scalars for no-cache queries, but comes at the cost that it runs on every response for every query. We would likely need an additional API from the cache that tells us when scalars are configured so that we can skip the work when a user isn't using scalars.

If we choose not to go this route, we'll need at least a TypeScript solution in place that can handle choosing the serialized types for custom scalar fields, that way users can handle the parsing logic in their apps as needed. This requires additional work in codegen to make work.

Note

This is an experiment and might not make it into the 4.3 release. We are still evaluating whether this makes sense.

@apollo-librarian

apollo-librarian Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: ffe0afb70fee214200b7a8f5
Build Logs: View logs


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 734c0c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 21f86632-a217-4721-a773-17d62bb43163

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 30, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@apollo/client@13372

commit: 734c0c9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant