fix: Local cache mutation generation when field merging disabled #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: da0721188710ec689bb12df0 |
✅ Deploy Preview for apollo-ios-docc canceled.
|
|
@BobaFetters - take a look at this one too if you'd like. I'll wait for @AnthonyMDev to review too before merging. |
AnthonyMDev
requested changes
May 28, 2025
Co-authored-by: Anthony Miller <[email protected]>
…m:apollographql/apollo-ios-dev into fix/fieldmerging-for-local-cache-mutation
|
OK @AnthonyMDev - ready for another review. |
Correct. I'm working on that one now. It'll be layered on top of this PR but this one can be merged before. I'd like to get them both merged before publishing the next release though. |
AnthonyMDev
approved these changes
May 30, 2025
BobaFetters
pushed a commit
that referenced
this pull request
May 30, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
May 30, 2025
BobaFetters
pushed a commit
that referenced
this pull request
May 30, 2025
1b1661ba fix: Local cache mutation generation when field merging disabled (#654) git-subtree-dir: apollo-ios-codegen git-subtree-split: 1b1661ba166f6cbb857c003d016e5891f4a6c554
BobaFetters
pushed a commit
that referenced
this pull request
May 30, 2025
…ation when field merging disabled git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 9c9efcc git-subtree-split: 1b1661ba166f6cbb857c003d016e5891f4a6c554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3554
The full set of selection set initializers must always be generated for local cache mutation operations and fragments. Before this change using a
fieldMergingpolicy of anything other thannonewould generate local cache mutations but they could not be initialized and did not contain all the correct merged fields.