Update librarian and workflows #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
approved these changes
Jun 30, 2025
| @@ -1,16 +1,16 @@ | |||
| name: Build pull request | |||
| name: check-pull-request | |||
There was a problem hiding this comment.
I tend to just remove the name these days since it duplicates the file name 🤷
|
|
||
| jobs: | ||
| build-pull-request: | ||
| check-pull-request: |
There was a problem hiding this comment.
I tend to use build-pull-request because it calls ./gradlew build
gradle/repositories.gradle.kts
Outdated
Comment on lines
13
to
20
| pluginManagement.repositories { | ||
| exclusiveContent { | ||
| forRepository { maven("https://storage.googleapis.com/gradleup/m2") } | ||
| filter { | ||
| includeGroup("com.gradleup.librarian") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I know we have this in other places but this is actually wrong. librarian is also released on Maven Central.
What we need is more the opposite:
maven("https://storage.googleapis.com/gradleup/m2") {
content {
includeGroup("com.gradleup.librarian")
}
}
Comment on lines
-581
to
-583
| final const val com.apollographql.cache.normalized/VERSION // com.apollographql.cache.normalized/VERSION|{}VERSION[0] | ||
| final fun <get-VERSION>(): kotlin/String // com.apollographql.cache.normalized/VERSION.<get-VERSION>|<get-VERSION>(){}[0] | ||
|
|
There was a problem hiding this comment.
Interesting that removing the const is a breaking change on native. No @JvmField there. I think it's OK though 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.