Use the cache directory by default #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
approved these changes
Oct 21, 2025
|
|
||
| PUT_CHANGELOG_HERE | ||
|
|
||
| - Database files are now stored in the `cache` directory by default on Android (#164) |
There was a problem hiding this comment.
Probably worth and explicit warning that it's going to lose all the data.
rohandhruva
reviewed
Oct 23, 2025
|
|
||
| else -> { | ||
| // Old versions of the library used to store the database in the database directory. | ||
| // If such file exists, use it, otherwise, use the cache directory. |
There was a problem hiding this comment.
For users who would prefer to switch to using the cache directory, do you think it's possible to provide a migration path? (understanding that you'll lose all the existing data)
There was a problem hiding this comment.
I think switching to the cache directory should become the default (with a big warning in the release notes). Users that want to keep the old one could use a dedicated overload that takes a path maybe?
There was a problem hiding this comment.
You can pass an absolute path for name, so I think that's enough to do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #164