Add CacheInfo.isStale #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CacheResolver.resolveField can return cache headers - Add STALE cache header and CacheInfo.isStale - Rename expirationDate -> staleDate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used to know if data was received from the cache even though it was stale (can happen when using
maxStale).To make this happen I had to change
ApolloStore.readOperation() / readFragment()to allow it to return cache headers (breaking!).CacheResolver.resolveField()can now also return cache headers (not breaking because it returnsAny?).In this PR also, rename
ExpirationCacheResolvertoCacheControlCacheResolver, and rename "Expiration" to "Cache control" in the documentation.Fixes #51