- 
                Notifications
    
You must be signed in to change notification settings  - Fork 682
 
          Introduce RetryDelegate
          #6764
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
  
    Introduce RetryDelegate
  
  #6764
              
            Conversation
          ✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: c66ffb3af42adffc92e7a920 URL: https://www.apollographql.com/docs/deploy-preview/c66ffb3af42adffc92e7a920  | 
    
| */ | ||
| return this is ApolloNetworkException | ||
| return when (this) { | ||
| is ApolloNetworkException, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC OfflineApolloException (which is a ApolloNetworkException) should be excluded here, otherwise we retry when we should fail fast if offline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I'll do something about it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright so I changed everything 😅 . Initial description updated.
RetryDelegate
      
See #5862 (comment)
In addition to the new API, this: