Skip to content

Allow multiple success responses in ApolloCall.execute() #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow multiple success responses in ApolloCall.execute() #6772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo/ApolloCall.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ class ApolloCall<D : Operation.Data> internal constructor(
*
* [execute] calls [toFlow] and filters out cache or network errors to return a single success [ApolloResponse].
*
* [execute] throws if more than one success [ApolloResponse] is returned, for an example, if [operation] is a subscription or a `@defer` query.
* In those cases use [toFlow] instead.
* If more than one success [ApolloResponse] is emitted, for an example, if [operation] is a subscription or a `@defer` query, the first one is returned.
* Prefer [toFlow] for those cases to handle all the responses.
*
* [execute] may fail due to an I/O error, a cache miss or other reasons. In that case, check [ApolloResponse.exception]:
* ```
Expand Down Expand Up @@ -208,8 +208,7 @@ class ApolloCall<D : Operation.Data> internal constructor(
}
}

1 -> successResponses.first()
else -> throw DefaultApolloException("The operation returned multiple items, use .toFlow() instead of .execute()")
else -> successResponses.first()
}
}
}
Loading