feat(smith) Backport configurable response generation#1033
Open
SharkBaitDLS wants to merge 1 commit intomainfrom
Open
feat(smith) Backport configurable response generation#1033SharkBaitDLS wants to merge 1 commit intomainfrom
SharkBaitDLS wants to merge 1 commit intomainfrom
Conversation
SharkBaitDLS
force-pushed
the
imgood/subgraph-mock-backport
branch
2 times, most recently
from
d251ef2 to
b5119cd
Compare
SharkBaitDLS
changed the title
When we built the Rust subgraph mock server, we started with apollo-smith's response generation code as our foundation. Over time, we've added more configuration flexibility and GraphQL spec-compliant behavior to that code, diverging from this source. This change backports those improvements and fixes and exposes configuration options that will allow the subgraph mock to just take a dependency on this code rather than remaining a fork of it.
SharkBaitDLS
force-pushed
the
imgood/subgraph-mock-backport
branch
from
b5119cd to
3c1dbc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we built the Rust subgraph mock server, we started with apollo-smith's response generation code as our foundation. Over time, we've added more configuration flexibility and GraphQL spec-compliant behavior to that code, diverging from this source. This change backports those improvements and fixes and exposes configuration options that will allow the subgraph mock to just take a dependency on this code rather than remaining a fork of it.