Skip to content

Add failing test for #916 #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add failing test for #916 #917

wants to merge 2 commits into from

Conversation

goto-bus-stop
Copy link
Member

It also reports this, which doesn't make sense:

Error: interface, union and object types must have a subselection set
   ╭─[0119_nested_subselection_issue_916.graphql:8:17]
   │
 8 │ query Invalid { me { name { reviews { body } } } }
   │                 ────────────────┬───────────────
   │                                 ╰───────────────── `Query.me` is an object type `User` and must select fields
───╯

It also reports this, which doesn't make sense:
```
Error: interface, union and object types must have a subselection set
   ╭─[0119_nested_subselection_issue_916.graphql:8:17]
   │
 8 │ query Invalid { me { name { reviews { body } } } }
   │                 ────────────────┬───────────────
   │                                 ╰───────────────── `Query.me` is an object type `User` and must select fields
───╯
```
@goto-bus-stop
Copy link
Member Author

goto-bus-stop commented Jan 29, 2025

The reason appears to be that the executable::Field's subselection gets emptied during ast -> executable conversion, and validation does not know about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant