demonstrate changes to get latest dual build v17 alpha graphql-js working with jest #8137
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
yaacovCR
force-pushed
the
test-esm
branch
2 times, most recently
from
4606a3c to
e35e9f9
Compare
- use jest config setting: testEnvironment / customExportConditions - use latest dev mode with dual build (see graphql/graphql-js#4464) - no need for additional transformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the latest version of
graphql-json main is dual esm/cjs build with proper exports map.graphql/graphql-js#4464 adds development mode via custom condition
This PR demonstrates how a consumer of
graphql-jsmight setup jest/ts-jest: simply add the custom exports conditionsdevelopment(while retainingnode) via the jest config testEnvironmentOptions / customExportConditionsCompare with earlier attempts for the previously proposed esm-only #8082 and #8083 which requires babel or swc => retaining the dual build simplifies these changes.