-
Notifications
You must be signed in to change notification settings - Fork 465
deps: Stop using fork of graphql-language-service-* packages.
#2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
deps: Stop using fork of graphql-language-service-* packages.
#2248
Conversation
This reverts commit 205987d.
Originally, we forked the `graphql-language-service-*` packages to avoid a dependency on `graphql-config` and `graphql-import` which were included as direct dependencies of those packages (and problematic because of their OWN dependency trees, at the time). That is no longer the case in the upstream packages. Furthermore, the TypeScript types that we wrote to utilize those packages (which were at the time written in Flow) are no longer necessary since the project has been ported to TypeScript. This is an attempt to switch them out for our own packages.
Otherwise, this doesn't compile because of an unspecified dependency on `graphql-config` in the upstream package.
The VSCode extension is no longer part of this repository after being removed in #2385
05c5c69 to
33b48ea
Compare
|
I ran into this issue as well. Poking around, I found a number of other issues that this PR would likely fix:
|
|
It seems that this PR might fixes a couples of issues like mentioned by @samuela. I've also encountered this issue 👉 #2422. This happens because
Because of that there are some projects I'm working on where we cannot upgrade a bunch of apollo and graphql dependencies 😞 Let me know if I can help in any way 🙂 ! |
|
Any update on this? |
Originally, we forked the
graphql-language-service-*packages to avoid adependency on
graphql-configandgraphql-importwhich were included asdirect dependencies of those packages (and problematic because of their OWN
dependency trees, at the time).
That is no longer the case in the upstream packages. Furthermore, the
TypeScript types that we wrote to utilize those packages (which were at the
time written in Flow) are no longer necessary since the project has been
ported to TypeScript.
This is an attempt to switch them out for non-forks.
Might fix #2232