Skip to content

Conversation

@abernix
Copy link
Member

@abernix abernix commented Mar 24, 2021

Originally, we forked the graphql-language-service-* packages to avoid a
dependency on graphql-config and graphql-import which were included as
direct dependencies of those packages (and problematic because of their OWN
dependency trees, at the time).

That is no longer the case in the upstream packages. Furthermore, the
TypeScript types that we wrote to utilize those packages (which were at the
time written in Flow) are no longer necessary since the project has been
ported to TypeScript.

This is an attempt to switch them out for non-forks.

Might fix #2232

Originally, we forked the `graphql-language-service-*` packages to avoid a
dependency on `graphql-config` and `graphql-import` which were included as
direct dependencies of those packages (and problematic because of their OWN
dependency trees, at the time).

That is no longer the case in the upstream packages.  Furthermore, the
TypeScript types that we wrote to utilize those packages (which were at the
time written in Flow) are no longer necessary since the project has been
ported to TypeScript.

This is an attempt to switch them out for our own packages.
Otherwise, this doesn't compile because of an unspecified dependency on
`graphql-config` in the upstream package.
The VSCode extension is no longer part of this repository after being
removed in #2385
@abernix abernix force-pushed the abernix/change-to-upstream-fork-graphql-language-service-pkgs branch from 05c5c69 to 33b48ea Compare August 24, 2021 07:35
@100terres
Copy link

100terres commented Dec 7, 2021

It seems that this PR might fixes a couples of issues like mentioned by @samuela.

I've also encountered this issue 👉 #2422. This happens because apollo-language-server is using the old @apollographql/graphql-language-service-interface deps which some of its own depencencies have a peer dependencie on graphql that does not go higher than v14.

apollo-tooling seems to support support v15, so when installing with npm/yarn both versions of graphql are installed which throws error when running some of the apollo cli commands.

Because of that there are some projects I'm working on where we cannot upgrade a bunch of apollo and graphql dependencies 😞

Let me know if I can help in any way 🙂 !

@Yiin
Copy link

Yiin commented Mar 11, 2022

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants