apollo-language-server: allow code generation from typescript generic graphql tag#2394
Open
hugo082 wants to merge 1 commit intoapollographql:masterfrom
Open
apollo-language-server: allow code generation from typescript generic graphql tag#2394hugo082 wants to merge 1 commit intoapollographql:masterfrom
hugo082 wants to merge 1 commit intoapollographql:masterfrom
Conversation
|
@hugo082: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
1d93a20 to
a8f6949
Compare
Allow to use generic graph tag like: graphql<TResponse>`{ myQuery }`
a8f6949 to
1bfd0f6
Compare
Author
|
@JakeDawkins what is the process to ask for a review/release? Maybe I need to post on a community channel? |
Author
|
@hwillson can you have a look at this PR? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow using Typescript code generation with a generic graph tag.
Example:
The regex is tested here. 2 tests don't pass but as they are not valid Typescript syntax it is not a problem.