Skip to content

fix(supergraph): Fix null check in error message #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qumberrizvi
Copy link

This PR fixes an error thrown by Typescript 5.x.

TS2869: Right operand of ?? is unreachable because the left operand is never nullish.

On line 163:

throw new UplinkFetcherError(fetchErrorMsg + result.status + ' ' + e.message ?? e);

Closes #3229

@qumberrizvi qumberrizvi requested a review from a team as a code owner March 30, 2025 04:41
@apollo-cla
Copy link

@qumberrizvi: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

changeset-bot bot commented Mar 30, 2025

⚠️ No Changeset found

Latest commit: 9649cd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Mar 30, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 3657aa7a135505357932d778

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadSupergraphSdlFromStorage throws TS2869
3 participants