Skip to content

Add new CompositionOption to bail if total number of subgraph path infos in the stack gets above a configured value. #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

clenfest
Copy link
Contributor

No description provided.

…fos in the stack gets above a configured value.
Copy link

changeset-bot bot commented May 13, 2025

🦋 Changeset detected

Latest commit: a657a82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@apollo/composition Patch
@apollo/federation-internals Patch
@apollo/gateway Patch
@apollo/query-planner Patch
@apollo/query-graphs Patch
@apollo/subgraph Patch
apollo-federation-integration-testsuite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented May 13, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 88dcda14f9857e3a84b1d6e7

Copy link

codesandbox-ci bot commented May 13, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@clenfest clenfest marked this pull request as ready for review May 14, 2025 15:36
@clenfest clenfest requested a review from a team as a code owner May 14, 2025 15:36
@clenfest clenfest marked this pull request as draft May 14, 2025 16:00
@clenfest clenfest marked this pull request as ready for review May 14, 2025 17:01
@sachindshinde sachindshinde self-requested a review May 14, 2025 17:12
Copy link
Contributor

@duckki duckki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look reasonable. Just a question.

Copy link
Contributor

@sachindshinde sachindshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that #3258 should help for the subgraph path issues we've been considering, but it would still be good to have this limit if there's other undiscovered issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants