Skip to content

deps: update apollo-compiler (backport #7338) #7350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Apr 28, 2025

This introduces a new validation rule, which will reject more queries than before, but it's not breaking because we already didn't support such queries in other parts of the router.

Changelog:


Features

  • Reject @skip/@include on subscription root fields - dariuszkuc SimonSapin and goto-bus-stop, pull/963

    This implements a GraphQL spec RFC, rejecting
    subscriptions in validation that can be invalid during execution.

  • New shorthand methods for mutable directive argument access - tninesling, pull/967

    Introduces new methods:

    • DirectiveList::get_all_mut
    • DirectiveList::argument_by_name_mut
    • DirectiveList::specified_argument_by_name_mut

Fixes

  • Update ariadne trait implementations - lrlna, pull/960

    [email protected] release changed their type signature for ariadne::Cache trait, which required an
    update to apollo-compiler's implementation of ariadne::Cache<FileId>.

    This release also had a slight change to path formatting, so if you had any snapshots in your
    tests, you can expect a change from this:

    Error: `typeFragment1` contains too much nesting
        ╭─[overflow.graphql:11:11]
    

    to this (notice the extra white space around the file path):

    Error: `typeFragment1` contains too much nesting
        ╭─[ overflow.graphql:11:11 ]
    
  • Harden stack overflow protection - goto-bus-stop, pull/966

    Closes a theoretical gap in stack overflow protection when processing long fragment chains, and
    significantly improves validation performance on documents with thousands of fragment definitions.


This is an automatic backport of pull request #7338 done by Mergify.

(cherry picked from commit cef3f13)

# Conflicts:
#	Cargo.lock
@goto-bus-stop goto-bus-stop requested a review from a team as a code owner April 28, 2025 10:49
@mergify mergify bot added the conflicts label Apr 28, 2025
Copy link
Contributor

mergify bot commented Apr 28, 2025

Cherry-pick of cef3f13 has failed:

On branch mergify/bp/1.x/pr-7338
Your branch is up to date with 'origin/1.x'.

You are currently cherry-picking commit cef3f130.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changesets/maint_renee_apollo_compiler_1_28.md
	modified:   Cargo.toml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Cargo.lock

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Apr 28, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 2a36996334945ec56eebb0a7

@goto-bus-stop goto-bus-stop requested review from a team as code owners April 28, 2025 12:38
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending merge conflicts!

@goto-bus-stop goto-bus-stop merged commit 8c307d1 into 1.x Apr 30, 2025
14 checks passed
@goto-bus-stop goto-bus-stop deleted the mergify/bp/1.x/pr-7338 branch April 30, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants