Skip to content

Use BoxCloneService instead of BoxService in router pipeline services#9161

Open
rohan-b99 wants to merge 10 commits intodev-v3.xfrom
rohan-b99/use-BoxCloneService
Open

Use BoxCloneService instead of BoxService in router pipeline services#9161
rohan-b99 wants to merge 10 commits intodev-v3.xfrom
rohan-b99/use-BoxCloneService

Conversation

@rohan-b99
Copy link
Copy Markdown
Contributor

@rohan-b99 rohan-b99 commented Apr 9, 2026

Originally opened #9145, but after discussing we think the Sync version is not needed


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@rohan-b99 rohan-b99 requested review from a team as code owners April 9, 2026 16:26
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Apr 9, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 3 changed, 0 removed
* graphos/routing/(latest)/customization/native-plugins.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/standard-instruments.mdx
* graphos/routing/(latest)/operations/subscriptions/configuration.mdx

Build ID: 8d766df525f4c434427bc4ca
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/8d766df525f4c434427bc4ca


✅ AI Style Review — No Issues Found

The pull request does not have any style issues.

Duration: 3938ms
Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@goto-bus-stop
Copy link
Copy Markdown
Member

goto-bus-stop commented Apr 10, 2026

I think a nice proof point for this PR would be to get rid of as many .buffered() calls as possible; we only had (most of) them to call into non-clonable services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants