-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update curl installer message for anonymized usage collection #1873
Update curl installer message for anonymized usage collection #1873
Conversation
While installing rover I noticed that the message printed was still showing the integer value instead of the boolean value. This was changed within the release v0.18.1. For the npm installer this message was updated already.
@hpuac: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Signed ✅ |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 8dfbca586bf0be572dd529c8 |
Today marks the one-year anniversary of this open PR. I hope you allow me a sarcastic comment: |
@hpuac - Sorry for the absurdly long delay. We've just started up a new tooling team here at Apollo which should allow us to more effeciently handle external pull requests (though admittedly one year is a very low bar to improve upon!). Thanks for your interest and contributions to Apollo! |
Closing in favor of #2448. The required GitHub actions for end-to-end tests in this repo aren't currently configured to work with PRs from forks. Since these changes are small, it's easier to just put them in a new PR. Sorry again for the delay on this. |
Changes from #1873. The E2E tests in this repo are not currently configured to allow PRs from forks, due to the way they use secrets. For now, creating a new PR for these changes. Co-authored-by: Hans Puac <[email protected]>
While installing rover I noticed that the message printed for disabling the anonymized usage collection was still suggesting to set
APOLLO_TELEMETRY_DISABLED=1
.But since the release v0.18.1 the recommendation was changed to use the boolean flag.
This PR updates the message for the curl installer.
For the npm installer this message was already correct/updated.