Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement supergraph config schema command #2418

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

jonathanrainer
Copy link
Contributor

This takes Dylan's work from #2139 and makes it work with the latest work in Rover

Essentially this allows us to take the work done in apollo-federation-types and expose it for others to consume in other IDEs etc.

@jonathanrainer jonathanrainer requested a review from a team as a code owner February 23, 2025 11:38
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Feb 23, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* (developer-tools)/rover/commands/supergraphs.mdx

Build ID: d8c4e3294c248982204571b6

URL: https://www.apollographql.com/docs/deploy-preview/d8c4e3294c248982204571b6

@jonathanrainer jonathanrainer force-pushed the jr/supergraph-config-json-schema branch from f1f3371 to 45950a6 Compare February 23, 2025 11:42
@jonathanrainer jonathanrainer requested a review from a team as a code owner February 23, 2025 11:58
@jonathanrainer jonathanrainer force-pushed the jr/supergraph-config-json-schema branch from 940c3f7 to 43f864c Compare February 23, 2025 12:07
This takes Dylan's work from #2139 and makes it work with
the latest work in Rover
@jonathanrainer jonathanrainer force-pushed the jr/supergraph-config-json-schema branch from 70d4163 to 394e550 Compare February 25, 2025 13:19
@jonathanrainer jonathanrainer changed the title Implement print-json-schema command Implement supergraph config schema command Feb 25, 2025
Copy link

@burn2delete burn2delete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonathanrainer jonathanrainer merged commit db193fe into main Mar 3, 2025
32 checks passed
@jonathanrainer jonathanrainer deleted the jr/supergraph-config-json-schema branch March 3, 2025 08:32
@pubmodmatt pubmodmatt added this to the vNext milestone Mar 10, 2025
@pubmodmatt pubmodmatt added the feature 🎉 new commands, flags, functionality, and improved error messages label Mar 10, 2025
@pubmodmatt pubmodmatt mentioned this pull request Mar 10, 2025
pubmodmatt added a commit that referenced this pull request Mar 12, 2025
# [0.28.0] - 2025-03-12

## 🚀 Features

- **Default to Apollo Router 2.x for `rover dev` - @pubmodmatt PR
#2433**

The default version of Apollo Router used by `rover dev` is now 2.x
instead of 1.x. The default can be overridden by
setting `APOLLO_ROVER_DEV_ROUTER_VERSION`, for example
`APOLLO_ROVER_DEV_ROUTER_VERSION=1.61.0`.

- **Implement supergraph config schema command - @jonathanrainer PR
#2418**

Adds a new `rover supergraph config schema` command to output the
JSONSchema for `supergraph.yaml`. This can be used to configure editor
support for the file.

## 🐛 Fixes

- **Add specific CompositionError handling - @jonathanrainer PR #2422**
- **Pass log_level through to Router binary - @monkpow PR #2426**
- **Fix formatting of table output by `rover config whoami` -
@pubmodmatt PR #2413**
- **Better error on missing environment variable - @pubmodmatt PR
#2442**

## 🛠 Maintenance

- **Add Apollo Router 2.x dependency to renovate - @pubmodmatt PR
#2430**
- **Fix CI post update to Rustup 1.28 - @jonathanrainer PR #2431**
- **Replace backoff with backon - @pubmodmatt PR #2437**
- **Add exemption for unmaintained humantime dependency - @pubmodmatt PR
#2440**

## 📚 Documentation

- **Add docs on using the native GitHub actions - @lleadbet PR #2419**
- **Add changelog entry for new behaviour w.r.t subgraph_url -
@jonathanrainer PR #2420**
- **GitHub CI/CD - @shorgi PR #2427**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants