Skip to content

refactor whoami route and update tests - #5045

Merged
BoDonkey merged 3 commits into
mainfrom
pro-8236-whoami-refactor
Aug 28, 2025
Merged

refactor whoami route and update tests#5045
BoDonkey merged 3 commits into
mainfrom
pro-8236-whoami-refactor

Conversation

@BoDonkey

Copy link
Copy Markdown
Contributor

Summary

Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR refactors the login/whoami route as accessible both by POST, which is recommended, and GET, for BC. It also updates the Mocha tests to use the recommended verb. Closes POST-8236.

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@BoDonkey
BoDonkey requested a review from boutell August 28, 2025 13:52
@linear

linear Bot commented Aug 28, 2025

Copy link
Copy Markdown

@BoDonkey
BoDonkey merged commit 15ec97e into main Aug 28, 2025
6 checks passed
@BoDonkey
BoDonkey deleted the pro-8236-whoami-refactor branch August 28, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants