Merged
Conversation
boutell
previously approved these changes
Sep 12, 2025
stuartromanek
requested changes
Sep 12, 2025
Member
stuartromanek
left a comment
stuartromanek
left a comment
There was a problem hiding this comment.
do not merge, styles need work, will update
stuartromanek
previously approved these changes
Sep 15, 2025
ValJed
commented
Sep 16, 2025
| } | ||
|
|
||
| .apos-modal__body-main { | ||
| flex-grow: 1; |
Contributor
Author
There was a problem hiding this comment.
@stuartromanek I just changed this line, replaced the height: 100%.
Also running cypress tests.
stuartromanek
approved these changes
Sep 16, 2025
ValJed
force-pushed
the
pro-8247-sections-empty-state
branch
from
0c528b4 to
f447d6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/apostrophecms/issue/PRO-8247/as-a-user-i-want-directions-for-how-to-add-my-first-section-so-that-i
Summary
What are the specific steps to test this change?
Cypress running: 🟠
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: