Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/postcss-bom-box-sizing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"apostrophe": patch
---

Fixed incorrect sizing and spacing across the admin UI in webpack builds. A byte order mark preserved by PostCSS 8.5.24 invalidated the stylesheet rule setting `box-sizing` for `.apos-` elements. Sass is now compiled with `charset: false` in webpack builds, so the marker is never emitted. Vite builds were unaffected.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ module.exports = (options, apos) => {
loader: 'sass-loader',
options: {
sassOptions: {
silenceDeprecations: [ 'import' ]
silenceDeprecations: [ 'import' ],
// Without this Sass emits a BOM, which postcss 8.5.24+ keeps.
// A BOM in the middle of a stylesheet kills the rule after it.
charset: false
},
sourceMap: false,
// "use" rules must come first or sass throws an error
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ module.exports = (options, apos, srcBuildNames) => {
loader: 'sass-loader',
options: {
sassOptions: {
silenceDeprecations: [ 'import' ]
silenceDeprecations: [ 'import' ],
// Without this Sass emits a BOM, which postcss 8.5.24+ keeps.
// A BOM in the middle of a stylesheet kills the rule after it.
charset: false
}
}
}
Expand Down
Loading