Skip to content

1.1.0: bug fixes, stomped out old references to alpha quality, corrected 3.x to 4.x (with bc)#19

Merged
boutell merged 3 commits intoreview-1.1.0from
main
Mar 3, 2026
Merged

1.1.0: bug fixes, stomped out old references to alpha quality, corrected 3.x to 4.x (with bc)#19
boutell merged 3 commits intoreview-1.1.0from
main

Conversation

@boutell
Copy link
Copy Markdown
Member

@boutell boutell commented Mar 2, 2026

The changes are in main, for Reasons (I thought I had to test github links, I don't anymore, see my PR code-upgrader)

But I've made this PR to a suitable base branch so you can review it properly before I publish.

@boutell boutell requested a review from BoDonkey March 2, 2026 21:13
@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment thread CHANGELOG.md
@@ -1,5 +1,11 @@
# Changelog

## 1.1.0 (2026-03-02)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget why we decided not to put this module in the monorepo, but I do remember talking about it!

Comment thread index.js
construct(self, options) {
self.a2ToA3Paths = new Map();
self.a2ToA3Ids = new Map();
self.a2ToA4Paths = new Map();
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency.

Comment thread index.js
};
self.connectToNewDb = async () => {
const uri = self.apos.argv['a3-db'];
const uri = self.apos.argv['a4-db'] || self.apos.argv['a3-db'];
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note backwards compatible.

Comment thread index.js
});
};
self.fixLastPublishedAt = async () => {
console.log('Fixing lastPublishedAt properties (may take a long time)...');
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the big reason others struggled to use the module. Nasty last-mile issue.

Comment thread index.js
doc.aposLocale = `${defaultLocale}:draft`;
doc.aposMode = 'draft';
if (!doc.trash) {
// The trash page itself *does* get published, oddly enough, or A4 is mad
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another last-mile hangup.

Comment thread index.js
// A4/A4 is a stickler for this property
const aposLocales = await self.docs.distinct('aposLocale');
const locales = [...new Set(aposLocales.map(name => name.split(':')[0]))];
// TODO mongodb batch operation might be smootehr than Promise.all
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO mongodb batch operation might be smootehr than Promise.all
// TODO mongodb batch operation might be smoother than Promise.all

@boutell boutell merged commit 76503e9 into review-1.1.0 Mar 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants