This repository was archived by the owner on Feb 26, 2026. It is now read-only.
Conversation
ETLaurent
commented
Sep 10, 2025
| [ 7, 3 ], | ||
| [ 8, 3 ], | ||
| [ 29, 3 ], | ||
| [ 30, 3 ], |
ETLaurent
changed the title
contain-nested optioncontain-nested option for external mixins
Contributor
Author
|
1 or 2 approvals will suffice |
ETLaurent
commented
Sep 15, 2025
| [ 64, 3 ], | ||
| [ 70, 3 ] | ||
| [ 70, 3 ], | ||
| [ 78, 3 ] |
Contributor
Author
There was a problem hiding this comment.
new error in bad.scss
ETLaurent
commented
Sep 15, 2025
| `Expected error message to include line ${position.join(':')} but it did not` | ||
| ); | ||
| }); | ||
| ${errorPositionsMessages.join('\n')}` |
Contributor
Author
There was a problem hiding this comment.
improve test error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
contain-nestedoption for external mixins known to contain nested rules.This answers the limitation of the plugin not being able to see mixin definitions from other files.
See apostrophecms/apostrophe#5042