APPSRE9806: Adding replica removal validation #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzana-nesic
changed the title
hemslo
reviewed
Mar 19, 2025
| @@ -128,6 +129,11 @@ def _validate_version_upgrade(self) -> None: | |||
| self.errors.append( | |||
| "To enable major version ugprades, allow_major_version_upgrade attribute must be set to True" | |||
| ) | |||
| # Read replica removal validation | |||
| if len(u.change.after["replicas"]) > 0: | |||
There was a problem hiding this comment.
what change can happen in replicas? Do you have an example and add it to current tests?
There was a problem hiding this comment.
and we manage replica and source instances in 2 different terraform state, run in different jobs, so this limitation shouldn't be apply here.
Instead we can check if replicas already upgraded to new version, then allow source instance to upgrade.
Signed-off-by: Suzana Nesic <[email protected]>
suzana-nesic
force-pushed
the
appsre9806-replica-error-validation
branch
from
8127e29 to
4ee7cb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We advise our tenants to remove read replicas before a RDS upgrade but do not have any error validations in case that step is missed. This PR is to add logic to enforce that message.
Solves the reconcile error:
DBUpgradeDependencyFailure: One or more of the DB Instance's read replicas need to be upgradedPR for non-managed erv2 instances: app-sre/qontract-reconcile#4873