Skip to content

fix: use exec form for CMD in Dockerfile to propagate signals - #515

Draft
siddharthlatest with Copilot wants to merge 2 commits into
devfrom
copilot/fix-signal-propagation-docker
Draft

fix: use exec form for CMD in Dockerfile to propagate signals#515
siddharthlatest with Copilot wants to merge 2 commits into
devfrom
copilot/fix-signal-propagation-docker

Conversation

Copilot AI commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

When using the shell form of CMD, Docker runs the command via /bin/sh -c, making the shell PID 1. The shell does not forward SIGINT/SIGTERM to child processes, so Ctrl+C and docker stop have no effect on the Node.js server.

Change

Switch CMD from shell form to exec form so Node.js runs as PID 1 and receives signals directly:

# Before
CMD node packages/dejavu-main/server.js

# After
CMD ["node", "packages/dejavu-main/server.js"]

@vercel

vercel Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dejavu Ready Ready Preview, Comment Jul 2, 2026 11:13am

Copilot AI linked an issue Jul 2, 2026 that may be closed by this pull request
Failure to propogate signals to Docker container #441
Open
Copilot AI changed the title [WIP] Fix failure to propagate signals to Docker container fix: use exec form for CMD in Dockerfile to propagate signals Jul 2, 2026
Copilot AI requested a review from siddharthlatest July 2, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthlatest siddharthlatest Awaiting requested review from siddharthlatest

Assignees

@siddharthlatest siddharthlatest

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failure to propogate signals to Docker container

2 participants

@siddharthlatest