feat: Add a real frame property of the element #1017
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mykola-mokhnach Please take a look, when you have time. |
mykola-mokhnach
changed the title
| // | ||
| // Use `wdRealFrameString` to obtain this value in a simplified string | ||
| // format, avoiding excessively long numeric values in the JSON output. | ||
| double factor = pow(10, 2); |
There was a problem hiding this comment.
I'm not sure if this conversation is really necessary. It's probably ok if we want to reduce json string size, but not ok if we just want to fetch the original native attribute value as is via the /attribute API
There was a problem hiding this comment.
Agree. It makes sense for me to return the original one as-is for the original motivation (to return actual value as possible in terms of pixel perfect)
anton-yereshchenko
force-pushed
the
features/add-real-frame-property
branch
from
21e78e4 to
06d7446
Compare
|
Thank you @mykola-mokhnach and @KazuCocoa for your notes |
KazuCocoa
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces support for retrieving the actual rendered frame of a UI element, providing a more precise representation than the standard
wdFramevalue.Motivation
The original
wdFrameproperty applies rounding logic, which in some cases may lead to inaccurate element sizes or positions.Example Case: iPhone 16 Pro Simulator
Consider the following scenario:
We have a button, and after launching the app, we retrieve its
frameusing either a UI test or from withinviewDidAppear.The returned
frameis:(190.66666666666666, 426.6666666666667, 20.666666666666686, 20.66666666666663)However, when requesting the same frame from WebDriverAgent (wdFrame), we receive:
(190, 426, 22, 22)This difference - sometimes exceeding 1 pt and occasionally reaching 2 pt - can lead to inconsistencies, especially when performing 'pixel-perfect' validations.
Proposed Solution
We can round the frame values to two decimal places, resulting in a more accurate and human-readable format:
(190.67, 426.67, 20.67, 20.67)Could we make some toggle in the configuration? To turn on this property?
Thanks for the idea with
nonPrefixedKeys.Ref: #1016