fix(plist): only read direct-child keys when parsing a dict - #295
Merged
Conversation
getElementsByTagName('key') is recursive, so keys from nested dicts leaked
into the parent object and a nested key could overwrite a parent key of the
same name. Walk direct children instead and skip past each parsed value.
mykola-mokhnach
approved these changes
Aug 20, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
## [5.14.5](v5.14.4...v5.14.5) (2026-08-20) ### Bug Fixes * **plist:** only read direct-child keys when parsing a dict ([#295](#295)) ([7d8c5c3](7d8c5c3))
|
🎉 This PR is included in version 5.14.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseDictusedgetElementsByTagName('key'), which is recursive. Keys from nested dicts were flattened into the parent object, and a nested key could overwrite a parent key of the same name.Now walks direct children only and skips past each parsed value.
Affects every XML plist path: usbmux device lists, lockdown responses, pair records, provisioning profiles, configuration profiles.
Tests: 3 cases added for nested key isolation, same-name shadowing, and dicts inside arrays.