fix(port-forwarding): destroy upstream socket when client disconnects during connect - #305
Merged
Merged
Conversation
mykola-mokhnach
approved these changes
Aug 27, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
## [5.16.2](v5.16.1...v5.16.2) (2026-08-27) ### Bug Fixes * **port-forwarding:** destroy upstream socket when client disconnects during connect ([#305](#305)) ([957181d](957181d))
|
🎉 This PR is included in version 5.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a socket leak in
DevicePortForwarder. Thecloseanderrorlisteners were attached to the local socket only after the upstream connection resolved. A client disconnect during that window was missed, the upstream socket stayed open and both sockets leaked untilstop. An abrupt client reset in the same window also threw an unhandlederrorevent.Now client
closeanderrorare tracked while the upstream connection is being established and the upstream socket is destroyed immediately if the client is already gone. Includes a unit test covering the early disconnect.