refactor: store local selected device as one class - #406
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how a locally selected device is stored for session creation by consolidating multiple module-level variables into a single SelectedLocalDevice object, and updates session creation logic/tests to consume the new accessor.
Changes:
- Replace multiple
selectedDevice*globals with aSelectedLocalDeviceclass +getSelectedLocalDevice()accessor. - Update capability-building logic in
create-sessionto read fromSelectedLocalDevice. - Update Jest mocks to reflect the new selection API.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/tools/session/select-device.ts |
Introduces SelectedLocalDevice and refactors selection functions to return it. |
src/tools/session/create-session.ts |
Switches Android/iOS capability building and platform validation to use getSelectedLocalDevice(). |
src/tests/tools/session/session.test.ts |
Updates mocks to provide getSelectedLocalDevice() instead of multiple getters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.85.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of multiple variables to simplify the structure.
No functional changes exist in this PR.