fix: add escape for ui - #411
Merged
Merged
Conversation
KazuCocoa
requested review from
Delta456,
SrinivasanTarget,
Copilot,
navin772 and
saikrishna321
June 18, 2026 06:31
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the locator generator UI by preventing HTML/JS injection through untrusted locator metadata and selectors, and adds a regression test to ensure escaping is applied consistently.
Changes:
- Escape element metadata (tagName/text/contentDesc/resourceId) and locator strategy/selector before rendering into HTML.
- Replace inline
onclickhandler generation withdata-*attributes + a delegated click listener. - Add Jest coverage to assert XSS payloads are escaped and inline event handlers are not emitted.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ui/mcp-ui-utils.ts | Escapes untrusted values in generated locator UI HTML and switches to delegated click handling for “Test” buttons. |
| src/tests/mcp-ui-utils.test.ts | Adds regression test ensuring locator UI output escapes malicious content and removes inline handlers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SrinivasanTarget
approved these changes
Jun 18, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 18, 2026
## [1.85.10](v1.85.9...v1.85.10) (2026-06-18) ### Bug Fixes * add escape for ui ([#411](#411)) ([e222bbb](e222bbb))
|
🎉 This PR is included in version 1.85.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is security fix.