feat(process-control): use remotexpc for terminateApp#2727
Merged
mykola-mokhnach merged 4 commits intoappium:masterfrom Feb 16, 2026
Merged
feat(process-control): use remotexpc for terminateApp#2727mykola-mokhnach merged 4 commits intoappium:masterfrom
terminateApp#2727mykola-mokhnach merged 4 commits intoappium:masterfrom
Conversation
KazuCocoa
approved these changes
Feb 12, 2026
Contributor
Author
|
Hi @mykola-mokhnach, could you also review this? Thanks! |
| } | ||
|
|
||
| async terminateApp(bundleId: string, platformVersion: string): Promise<boolean> { | ||
| // For iOS 18 and above, use RemoteXPC DVT service. |
Contributor
There was a problem hiding this comment.
this method is too complicated now. consider refactoring it into smaller private methods
Member
There was a problem hiding this comment.
This repo has a similar implementation, so I think such a refactor could be a follow-up PR with several places together. Just an option.
Contributor
Author
There was a problem hiding this comment.
Yeah, we could do this in a separate PR
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
## [10.22.0](v10.21.3...v10.22.0) (2026-02-16) ### Features * **process-control:** use remotexpc for `terminateApp` ([#2727](#2727)) ([e89b9e3](e89b9e3))
Contributor
|
🎉 This PR is included in version 10.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses remotexpc when ios>=18 for the
terminateAppfunction, thekillAppmobile command utilizes this function.The code logic as per the ios versions:
devicectl