chore: Restore the legacy method of killing a process#2731
Merged
mykola-mokhnach merged 3 commits intoappium:masterfrom Feb 17, 2026
Merged
chore: Restore the legacy method of killing a process#2731mykola-mokhnach merged 3 commits intoappium:masterfrom
mykola-mokhnach merged 3 commits intoappium:masterfrom
Conversation
eglitise
approved these changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores support for terminating apps on iOS versions below 17 by reintroducing the legacy instrument service method. PR #2730 had simplified the terminateApp logic but dropped support for iOS 16 and lower by only using devicectl. This change adds conditional logic to handle iOS < 17 devices using the instrument service while keeping the devicectl path for iOS 17+.
Changes:
- Added imports for
servicesandINSTRUMENT_CHANNELfromappium-ios-device - Modified
terminateAppLegacyto check platform version and branch accordingly - iOS >= 17: uses devicectl to list and kill processes (existing behavior)
- iOS < 17: uses instrument service to find and kill processes (restored legacy behavior)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
## [10.23.1](v10.23.0...v10.23.1) (2026-02-17) ### Miscellaneous Chores * Restore the legacy method of killing a process ([#2731](#2731)) ([395e8bc](395e8bc))
Contributor
|
🎉 This PR is included in version 10.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #2730 (comment)