Skip to content

Adding RETRYABLE_VERIFICATION_FAILURE for OCSP network failures #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Adding RETRYABLE_VERIFICATION_FAILURE for OCSP network failures #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/apple/itunes/storekit/verification/ChainVerifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import java.security.PublicKey;
import java.security.cert.CertPath;
import java.security.cert.CertPathValidator;
import java.security.cert.CertPathValidatorException;
import java.security.cert.Certificate;
import java.security.cert.CertificateFactory;
import java.security.cert.PKIXCertPathValidatorResult;
Expand Down Expand Up @@ -113,6 +114,10 @@ PublicKey verifyChainWithoutCaching(String[] certificates, boolean performRevoca
PKIXCertPathValidatorResult certPathValidatorResult = (PKIXCertPathValidatorResult) certPathValidator.validate(certPath, parameters);
return certPathValidatorResult.getPublicKey();
} catch (Exception e) {
// This indicates an OCSP network failure
if (e instanceof CertPathValidatorException && ((CertPathValidatorException) e).getReason() == CertPathValidatorException.BasicReason.UNDETERMINED_REVOCATION_STATUS) {
throw new VerificationException(VerificationStatus.RETRYABLE_VERIFICATION_FAILURE);
}
throw new VerificationException(VerificationStatus.INVALID_CHAIN, e);
}
}
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/apple/itunes/storekit/verification/VerificationStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
public enum VerificationStatus {
OK,
VERIFICATION_FAILURE,
RETRYABLE_VERIFICATION_FAILURE,
INVALID_APP_IDENTIFIER,
INVALID_ENVIRONMENT,
INVALID_CERTIFICATE,
Expand Down
Loading