Implement Protocol-Based Testing with Sendable Conformance in AppStoreServerAPIClient #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of initializing a http client pool, expose the httpClient through the initializer or default on .shared that way we can share the http pool with others Deinit is no longer needed since httpclient is exposed Create a configuration struct so we are able to throw when initializing config & have a non throwing client initializer
…it tests, since AppStoreServerAPIClient is a final Sendable class now
StefanPrintezis
changed the title
Joannis
reviewed
Jun 20, 2025
| // try! used for example purposes only | ||
| let client = try! AppStoreServerAPIClient(signingKey: encodedKey, keyId: keyId, issuerId: issuerId, bundleId: bundleId, environment: environment) | ||
| let config = try! AppStoreServerAPIConfiguration(signingKeyPem: encodedKey, keyId: keyId, issuerId: issuerId, bundleId: bundleId, environment: environment) | ||
| let client = AppStoreServerAPIClient(config: config) |
There was a problem hiding this comment.
Is breaking out the configuration necessary for Sendable conformance? Why was this change made
| transactionHistoryRequest.sort = TransactionHistoryRequest.Order.ascending | ||
| transactionHistoryRequest.revoked = false | ||
| transactionHistoryRequest.productTypes = [TransactionHistoryRequest.ProductType.autoRenewable] | ||
| let transactionHistoryRequest = TransactionHistoryRequest( |
There was a problem hiding this comment.
This seems unrelated to to the proposed changes in this PR
| } | ||
|
|
||
| public enum APIResult<T> { | ||
| public enum APIResult<T: Sendable>: Sendable{ |
There was a problem hiding this comment.
Is this the only change in this PR necessary to actually make this Sendable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a protocol-based testing approach inspired by Soto's AWSHTTPClient pattern, making AppStoreServerAPIClient conform to Sendable, and improves the overall architecture for better testability and concurrency safety.
Protocol-Based HTTP Client Architecture
Configuration Improvements
Testing
Documentation Updates