Save O_PROJ on Fuji 70B-v2 for TRN2 #1147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruomingp
approved these changes
May 9, 2025
apoorvtintin
force-pushed
the
neuron_save_o_proj
branch
from
230a7c0 to
cf36791
Compare
|
Rebased the PR to fix failing CI |
|
I see the CI fails for test This is unrelated to the changes in this PR, I already rebased the PR to 12th May. Can I please get some guidance on how I can fix this? Thank you! |
|
apoorvtintin
force-pushed
the
neuron_save_o_proj
branch
from
cf36791 to
5966cc5
Compare
|
Rebased to disable flaky test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving out-projection improves training throughput while still fitting in the mesh defined by
neuron-(trn2|trn2n).48xlarge-64.