fix: Scale QK in vision/attention #1154
Open
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruomingp
reviewed
May 4, 2025
axlearn/vision/attention.py
Outdated
Comment on lines
218
to
227
| # Scale query and key. | ||
| key_positions = jnp.arange(k_proj.shape[1])[None, :] | ||
| q_proj, k_proj = self._scale_qk( | ||
| q_proj=q_proj, | ||
| k_proj=k_proj, | ||
| query_positions=query_positions, | ||
| key_positions=key_positions, | ||
| ) |
There was a problem hiding this comment.
Is there a unittest that can be added?
There was a problem hiding this comment.
Done - I added a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WindowAttentionlayer in vision/attention.py overrides the forward calls directly so we need to scale the QK before computing logits.