[JAX API Update] Remove jax_spmd_mode from config
#1160
Closed
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ruoming Pang <[email protected]>
apghml
approved these changes
May 6, 2025
ruomingp
approved these changes
May 17, 2025
|
Does this PR also need the validator? #1126 (comment) |
|
Hey @dmarx |
|
@Steboss Is this PR ready to merge? |
|
@apghml yes it is :) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I believe they fixed the issue recently. Can you merge the latest |
|
Also, @Steboss I see many of your recent PRs have been closed. Are you moving them somewhere else? If so, can you share a link? Thanks! |
|
That PR seems to be by a different user? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refers to PR #1136
jax_spmd_modeis now obsoletefuji-3B-v3-flash-attention, and results are still matching the previous implementation:@apghml if you could review this please. thank you