-
Notifications
You must be signed in to change notification settings - Fork 335
[JAX API Update] Remove jax_spmd_mode
from config
#1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Ruoming Pang <[email protected]>
Does this PR also need the validator? #1126 (comment) |
Hey @dmarx |
@Steboss Is this PR ready to merge? |
@apghml yes it is :) |
I believe they fixed the issue recently. Can you merge the latest |
Also, @Steboss I see many of your recent PRs have been closed. Are you moving them somewhere else? If so, can you share a link? Thanks! |
That PR seems to be by a different user? |
This refers to PR #1136
jax_spmd_mode
is now obsoletefuji-3B-v3-flash-attention
, and results are still matching the previous implementation:@apghml if you could review this please. thank you