Add max_len arg to fake_speech_source(). #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markblee Could you review? From 1365 |
markblee
approved these changes
May 27, 2025
ds-hwang
force-pushed
the
fake
branch
7 times, most recently
from
d5f1695 to
e72365c
Compare
markblee
approved these changes
May 30, 2025
| @@ -216,7 +216,7 @@ def test_visualize(self, input_shape: Sequence[int], **kwargs): | |||
| outputs = self._generate_masks( | |||
| dict(inputs=inputs, paddings=paddings), is_training=True, **kwargs | |||
| ) | |||
| # pylint: disable-next=import-outside-toplevel | |||
| # pylint: disable-next=import-outside-toplevel,import-error | |||
| import matplotlib.pyplot as plt | |||
There was a problem hiding this comment.
Do you need # pytype: disable=import-error?
There was a problem hiding this comment.
I think # pylint: disable-next=import-outside-toplevel,import-error contain # pytype: disable=import-error.
Let me see CI work
There was a problem hiding this comment.
You are right. # pylint: disable-next=import-error doesn't work as it's pytype error.
I added # pytype: disable=import-error.
fake_speech_source() generates extremely short fake audio samples (lengths like 1, 2, 3 and so on), which causes gradients to be zero in gradient unit tests.
markblee
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fake_speech_source() generates extremely short fake audio samples (lengths like 1, 2, 3 and so on), which causes gradients to be zero in gradient unit tests.