Ensure GCS bucket region matches config region #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethanlm
reviewed
May 30, 2025
| @@ -375,6 +381,8 @@ def run(self): | |||
| cfg: BaseBastionManagedJob.Config = self.config | |||
| from_vm = running_from_vm() | |||
|
|
|||
| validate_region_matching(gcp_settings("private_bucket"), gcp_settings("zone")) | |||
There was a problem hiding this comment.
private_bucket is used for quota files, not for data or checkpoints
Also gcp_settings is read from the static config file, users don't usually change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the region of the GCS bucket matches the cluster region for axlearn jobs. Requires user input to confirm whether they would like to continue despite region mismatch.