Support launching CPU jobset #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethanlm
reviewed
May 29, 2025
axlearn/cloud/gcp/runners/utils.py
Outdated
| is_pending: Whether the job can be recreated with minimal impact to uptime. | ||
|
|
||
| Returns: | ||
| A verdict of recreate or not. | ||
| """ | ||
| if processor_type != "tpu": | ||
| # We only consider recreation for TPU only jobs. | ||
| # types. |
There was a problem hiding this comment.
nit: we need to remove "types"
nit (my bad): change "for TPU only jobs" to "for TPU jobs."
Ethanlm
approved these changes
May 29, 2025
markblee
approved these changes
May 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.