feat(ci): adding golangci-lint by hjoshi123 · Pull Request #35 · apple/container-builder-shim

hjoshi123 · 2025-06-28T18:57:11Z

Fixes #27.

Added the following linters:

    - asasalint
    - asciicheck
    - bidichk
    - bodyclose
    - canonicalheader
    - contextcheck
    - copyloopvar
    - decorder
    - dogsled
    - dupword
    - durationcheck
    - errcheck
    - errchkjson
    - errname
    - exhaustive
    - exptostd
    - forbidigo
    - gocheckcompilerdirectives
    - gochecksumtype
    - gocritic
    - goheader
    - goprintffuncname
    - gosec
    - gosmopolitan
    - govet
    - grouper
    - importas
    - ineffassign
    - interfacebloat
    - intrange
    - loggercheck
    - makezero
    - mirror
    - misspell
    - musttag
    - nakedret
    - nilerr
    - nilnil
    - noctx
    - nosprintfhostport
    - predeclared
    - promlinter
    - protogetter
    - reassign
    - sloglint
    - staticcheck
    - tagalign
    - testableexamples
    - unconvert
    - unparam
    - unused
    - usestdlibvars
    - usetesting
    - wastedassign

Signed-off-by: hjoshi123 <hemant.joshi@vizio.com>

katiewasnothere · 2025-06-30T18:06:26Z

Hi @hjoshi123 thank you for the change! Was there a particular reason you chose this set of checks?

katiewasnothere · 2025-06-30T19:22:45Z

+    gci:
+      sections:
+        - standard
+        - defaul


katiewasnothere · 2025-06-30T19:23:13Z

+    - exhaustive
+    - exptostd
+    - forbidigo
+    - ginkgolinter


I'm not sure we need this. We don't have any ginkgo tests in this repo.

katiewasnothere · 2025-06-30T19:26:09Z

+      ci_install=true
+  fi
+  if [[ "$ci_install" == true ]]; then
+      curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/cc3567e3127d8530afb69be1b7bd20ba9ebcc7c1/install.sh \


In the other container project repos, we tend to install things under a .local directory for make to use (example https://github.com/apple/container/blob/9eb2f860fc35a933e7894bc5313e3b79cd001c52/Makefile#L162).

katiewasnothere · 2025-06-30T19:34:15Z

+      ci_install=true
+  fi
+  if [[ "$ci_install" == true ]]; then
+      curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/cc3567e3127d8530afb69be1b7bd20ba9ebcc7c1/install.sh \


I think we could do something like this for the address

https://raw.githubusercontent.com/golangci/golangci-lint/${GOLANGCI_LINTER_VERSION}/install.sh

Yup that makes sense.. changing it

hjoshi123 · 2025-07-01T00:16:42Z

Hi @hjoshi123 thank you for the change! Was there a particular reason you chose this set of checks?

Some of them were mentioned by default in the golangci lint docs and then I referred some of the k8s repos for others. Will make changes to remove some of them which are irrelevant as you mentioned.

katiewasnothere · 2025-07-09T21:37:56Z

@hjoshi123 Were you able to make the changes here?

hjoshi123 · 2025-07-12T03:33:21Z

@katiewasnothere sorry was busy with work.. will push the changes by this weekend.

Signed-off-by: hjoshi123 <mail@hjoshi.me>

katiewasnothere · 2025-07-14T21:00:07Z

+
+.PHONY: go-lint
+go-lint: golangci-lint-install
+	$(GOLANGCI_LINT) config verify


I don't think this will work when the script has installed golangci-lint under .local/bin. I think following something similar to what we do for installing protoc would be good. What do you think?

katiewasnothere · 2025-07-14T21:00:44Z

+
+install_golangci() {
+  ci_install=false
+  if [[ -x $(which golangci-lint) ]]; then


I think which will not find the binary if it's installed under .local/bin

katiewasnothere · 2025-07-14T21:03:23Z

+      if [[ "${version}" == "${GOLANGCI_LINTER_VERSION#v}" ]]; then
+          ci_install=false
+        else
+          ci_install=true


If we do something like how we install protoc, we get the check for whether to install golangci-lint for free since make will check if the file path exists, as it does for protoc here. Does that make sense?

katiewasnothere · 2025-07-14T21:06:40Z

-      - name: Check protobufs 
-        run: | 
+      - name: Verify linter configuration and Lint go code
+        uses: golangci/golangci-lint-action@v8


I think we should instead call the makefile command to install golangci-lint and then run it. That way the behavior is the same between local dev and the CI run.

Also the CI right now won't run for this PR right now since golangci/golangci-lint-action@v8 is not in our allowlist for actions that can be run

katiewasnothere · 2025-09-22T19:15:57Z

Closing for now since there haven't been updates on this PR in the last month. Please feel free to reopen.

adding lint config with github actions build

6796e51

Signed-off-by: hjoshi123 <hemant.joshi@vizio.com>

katiewasnothere reviewed Jun 30, 2025

View reviewed changes

Comment thread .golangci.yaml Outdated

gci:

sections:

- standard

- defaul

katiewasnothere Jun 30, 2025

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default

katiewasnothere reviewed Jun 30, 2025

View reviewed changes

Comment thread scripts/install-tools.sh

removed linters and changed golangci path

2b01c85

Signed-off-by: hjoshi123 <mail@hjoshi.me>

hjoshi123 requested a review from katiewasnothere July 13, 2025 18:06

katiewasnothere reviewed Jul 14, 2025

View reviewed changes

katiewasnothere closed this Sep 22, 2025

Uh oh!

Conversation

hjoshi123 commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

katiewasnothere commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hjoshi123 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

katiewasnothere commented Jul 9, 2025

Uh oh!

hjoshi123 commented Jul 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

katiewasnothere commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hjoshi123 commented Jun 28, 2025 •

edited

Loading

hjoshi123 commented Jul 1, 2025 •

edited

Loading

katiewasnothere commented Sep 22, 2025 •

edited

Loading