Skip to content

Add comments explaining usage of reference in call to Resolver #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katiewasnothere merged 1 commit into from
Jun 30, 2025
Merged

Add comments explaining usage of reference in call to Resolver #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/build/frontend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,13 @@ func resolveStates(ctx context.Context, bopts *BOpts, platform ocispecs.Platform
resolverOpts.ImageOpt = &sourceresolver.ResolveImageOpt{
ResolveMode: llb.ResolveModePreferLocal.String(),
}

// `resolvedBaseStageName.Result` is the image name as it was specified in the Dockerfile
// with the build args applied
// NOTE: DO NOT USE `ref.String()` in the call to ResolveImageConfig
// `ref`` is the qualified reference, with a default domain
// In case of local images, where there is no registry, resolution will fail
// due to the addition of the default domain.
_, digest, img, err := bopts.Resolver.ResolveImageConfig(ctx, resolvedBaseStageName.Result, resolverOpts)
if err != nil {
if err == reference.ErrObjectRequired {
Expand All @@ -188,6 +195,7 @@ func resolveStates(ctx context.Context, bopts *BOpts, platform ocispecs.Platform
}
name := strings.TrimSuffix(dref.FamiliarString(named), ":latest")

// pname constructs a platform-qualified image reference in the format buildkit requires for digest resolution
pname := name + "::" + platforms.FormatAll(platforms.Normalize(platform))
imgMetaMap := map[string][]byte{
exptypes.ExporterImageConfigKey: img,
Expand Down
Loading