Skip to content

Allow referencing previous stages as source in FROM #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katiewasnothere merged 1 commit into from
Jul 16, 2025
Merged

Allow referencing previous stages as source in FROM #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/build/frontend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func resolveStates(ctx context.Context, bopts *BOpts, platform ocispecs.Platform
states := map[string]stateMeta{}
stateLock := sync.Mutex{}

for _, stage := range stages {
for i, stage := range stages {
wg.Add(1)
go func(stage instructions.Stage) {
defer wg.Done()
Expand All @@ -145,6 +145,12 @@ func resolveStates(ctx context.Context, bopts *BOpts, platform ocispecs.Platform
return
}

// if there's another stage with this name before the current stage, that will be used as the source
namedIndex, hasNamedStage := instructions.HasStage(stages, resolvedBaseStageName.Result)
if hasNamedStage && namedIndex < i {
return
}

ref, err := dref.ParseAnyReference(resolvedBaseStageName.Result)
if err != nil {
if err == reference.ErrObjectRequired {
Expand Down
Loading